netdev - Re: [PATCH net-next v5] bridge: multicast to unicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170124101215.4e3017b2@xeon-e3>
Date:   Tue, 24 Jan 2017 10:12:15 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Linus Lüssing <linus.luessing@...3.blue>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Felix Fietkau <nbd@....name>,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH net-next v5] bridge: multicast to unicast

On Sat, 21 Jan 2017 21:01:32 +0100
Linus Lüssing <linus.luessing@...3.blue> wrote:

> +static bool br_port_group_equal(struct net_bridge_port_group *p,
> +				struct net_bridge_port *port,
> +				const unsigned char *src)
> +{
> +	if (p->port != port)
> +		return false;
> +
> +	if (!(port->flags & BR_MULTICAST_TO_UNICAST))
> +		return true;
> +
> +	return ether_addr_equal(src, p->eth_addr);
> +}
> +

I prefer that argument to functions like this be const.