netdev - Re: [PATCH net-next v5 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170124.133613.1355073769005063451.davem@davemloft.net>
Date:   Tue, 24 Jan 2017 13:36:13 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     martin.blumenstingl@...glemail.com
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-amlogic@...ts.infradead.org, robh+dt@...nel.org,
        mark.rutland@....com, carlo@...one.org, khilman@...libre.com,
        narmstrong@...libre.com
Subject: Re: [PATCH net-next v5 0/2] stmmac: dwmac-meson8b: configurable
 RGMII TX delay

From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Date: Sun, 22 Jan 2017 23:02:44 +0100

> Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4
> cycle (= 2ns) TX clock delay. This seems to work fine for many boards
> (for example Odroid-C2 or Amlogic's reference boards) but there are
> some others where TX traffic is simply broken.
> There are probably multiple reasons why it's working on some boards
> while it's broken on others:
> - some of Amlogic's reference boards are using a Micrel PHY
> - hardware circuit design
> - maybe more...
> 
> iperf3 results on my Mecool BB2 board (Meson GXM, RTL8211F PHY) with
> TX clock delay disabled on the MAC (as it's enabled in the PHY driver).
> TX throughput was virtually zero before:
 ...
> I get similar TX throughput on my Meson GXBB "MXQ Pro+" board when I
> disable the PHY's TX-delay and configure a 4ms TX-delay on the MAC.
> So changes to at least the RTL8211F PHY driver are needed to get it
> working properly in all situations.

Series applied, thanks.