netdev - Re: [patch net] mlxsw: spectrum_router: Correctly reallocate adjacency entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Jan 2017 13:45:02 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, eladr@...lanox.com
Subject: Re: [patch net] mlxsw: spectrum_router: Correctly reallocate
 adjacency entries

From: Jiri Pirko <jiri@...nulli.us>
Date: Mon, 23 Jan 2017 11:11:42 +0100

> From: Ido Schimmel <idosch@...lanox.com>
> 
> mlxsw_sp_nexthop_group_mac_update() is called in one of two cases:
> 
> 1) When the MAC of a nexthop needs to be updated
> 2) When the size of a nexthop group has changed
> 
> In the second case the adjacency entries for the nexthop group need to
> be reallocated from the adjacency table. In this case we must write to
> the entries the MAC addresses of all the nexthops that should be
> offloaded and not only those whose MAC changed. Otherwise, these entries
> would be filled with garbage data, resulting in packet loss.
> 
> Fixes: a7ff87acd995 ("mlxsw: spectrum_router: Implement next-hop routing")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied.