netdev - Re: [PATCH net-next 0/5] External MDIO support for mv88e6xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170124.160750.354090492587505672.davem@davemloft.net>
Date:   Tue, 24 Jan 2017 16:07:50 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     vivien.didelot@...oirfairelinux.com
Cc:     andrew@...n.ch, netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH net-next 0/5] External MDIO support for mv88e6xxx

From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Date: Tue, 24 Jan 2017 16:05:08 -0500

> Hi David,
> 
> David Miller <davem@...emloft.net> writes:
> 
>> Series applied, thanks Andrew.
>>
>> There seems to be a bit of inconsistency wrt. tab vs. space for
>> indentation in the binding files, just FYI.  I had to make some small
>> adjustments to this patch series in order to keep GIT from warning
>> when I applied this stuff.
> 
> Andrew just replied to my comment an hour ago, and I still have concerns
> about the patchset. I didn't like the list_head of busses, and the 6352
> family don't support the external mode. That needed to be addressed.
> 
> Why such an hurry to merge patches?

Because my backlog sucks otherwise?

I can revert, or you can ask Andrew to post follow-on fixups to
satisfy your concerns.  Just because I applied it doesn't make it
the end of the world.

And maybe I should apply patches aggressively, as this lights a fire
under everyone's butt and people review and fix things more quickly.

:-)