netdev - Re: [PATCH net v3 0/2] net: Fix oops on state free after lwt module unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170124.162156.732256204420312210.davem@davemloft.net>
Date:   Tue, 24 Jan 2017 16:21:56 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     rshearma@...cade.com
Cc:     netdev@...r.kernel.org, tom@...bertland.com,
        roopa@...ulusnetworks.com
Subject: Re: [PATCH net v3 0/2] net: Fix oops on state free after lwt
 module unload

From: Robert Shearman <rshearma@...cade.com>
Date: Tue, 24 Jan 2017 16:26:46 +0000

> An oops is seen in lwtstate_free after an lwt ops module has been
> unloaded. This patchset fixes this by preventing modules implementing
> lwtunnel ops from being unloaded whilst there's state alive using
> those ops. The first patch adds fills in a new owner field in all lwt
> ops and the second patch makes use of this to reference count the
> modules as state is built and destroyed using them.
> 
> Changes in v3:
>  - don't put module reference if try_module_get fails on building state
> 
> Changes in v2:
>  - specify module owner for all modules as suggested by DaveM
>  - reference count all modules building lwt state, not just those ops
>    implementing destroy_state, as also suggested by DaveM.
>  - rebased on top of David Ahern's lwtunnel changes

Applied and queued up for -stable.

Thanks.