netdev - Re: [PATCH net] net: dsa: Mop up remaining NET_DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201701252341.RjvGYBZ8%fengguang.wu@intel.com>
Date:   Wed, 25 Jan 2017 23:53:13 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     kbuild-all@...org, David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, valentinrothberg@...il.com,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net] net: dsa: Mop up remaining NET_DSA_HWMON references

Hi Andrew,

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Andrew-Lunn/net-dsa-Mop-up-remaining-NET_DSA_HWMON-references/20170125-221411
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net/dsa/dsa.c: In function 'dsa_switch_setup_one':
>> net/dsa/dsa.c:447:15: error: 'struct dsa_switch' has no member named 'hwmon_name'
      scnprintf(ds->hwmon_name, sizeof(ds->hwmon_name), "%s_dsa%d",
                  ^~
   net/dsa/dsa.c:447:38: error: 'struct dsa_switch' has no member named 'hwmon_name'
      scnprintf(ds->hwmon_name, sizeof(ds->hwmon_name), "%s_dsa%d",
                                         ^~
>> net/dsa/dsa.c:449:5: error: 'struct dsa_switch' has no member named 'hwmon_dev'
      ds->hwmon_dev = hwmon_device_register_with_groups(NULL,
        ^~
   net/dsa/dsa.c:450:8: error: 'struct dsa_switch' has no member named 'hwmon_name'
         ds->hwmon_name, ds, dsa_hwmon_groups);
           ^~
   net/dsa/dsa.c:451:16: error: 'struct dsa_switch' has no member named 'hwmon_dev'
      if (IS_ERR(ds->hwmon_dev))
                   ^~
   net/dsa/dsa.c:452:6: error: 'struct dsa_switch' has no member named 'hwmon_dev'
       ds->hwmon_dev = NULL;
         ^~
   net/dsa/dsa.c: In function 'dsa_switch_destroy':
   net/dsa/dsa.c:518:8: error: 'struct dsa_switch' has no member named 'hwmon_dev'
     if (ds->hwmon_dev)
           ^~
   net/dsa/dsa.c:519:29: error: 'struct dsa_switch' has no member named 'hwmon_dev'
      hwmon_device_unregister(ds->hwmon_dev);
                                ^~

vim +447 net/dsa/dsa.c

51579c3f Guenter Roeck 2014-10-29  441  		/* Create valid hwmon 'name' attribute */
51579c3f Guenter Roeck 2014-10-29  442  		for (i = j = 0; i < IFNAMSIZ && netname[i]; i++) {
51579c3f Guenter Roeck 2014-10-29  443  			if (isalnum(netname[i]))
51579c3f Guenter Roeck 2014-10-29  444  				hname[j++] = netname[i];
51579c3f Guenter Roeck 2014-10-29  445  		}
51579c3f Guenter Roeck 2014-10-29  446  		hname[j] = '\0';
51579c3f Guenter Roeck 2014-10-29 @447  		scnprintf(ds->hwmon_name, sizeof(ds->hwmon_name), "%s_dsa%d",
51579c3f Guenter Roeck 2014-10-29  448  			  hname, index);
51579c3f Guenter Roeck 2014-10-29 @449  		ds->hwmon_dev = hwmon_device_register_with_groups(NULL,
51579c3f Guenter Roeck 2014-10-29  450  					ds->hwmon_name, ds, dsa_hwmon_groups);
51579c3f Guenter Roeck 2014-10-29  451  		if (IS_ERR(ds->hwmon_dev))
51579c3f Guenter Roeck 2014-10-29  452  			ds->hwmon_dev = NULL;

:::::: The code at line 447 was first introduced by commit
:::::: 51579c3f1a9192b75365576227d40c7619493285 net: dsa: Add support for reporting switch chip temperatures

:::::: TO: Guenter Roeck <linux@...ck-us.net>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (57926 bytes)