netdev - Re: [PATCH net 0/3] bnxt_en: Fix RTNL lock usage in bnxt_sp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Jan 2017 13:27:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     michael.chan@...adcom.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net 0/3] bnxt_en: Fix RTNL lock usage in bnxt_sp_task().

From: Michael Chan <michael.chan@...adcom.com>
Date: Wed, 25 Jan 2017 02:55:06 -0500

> There are 2 function calls from bnxt_sp_task() that have buggy RTNL
> usage.  These 2 functions take RTNL lock under some conditions, but
> some callers (such as open, ethtool) have already taken RTNL.  These
> 3 patches fix the issue by making it clear that callers must take
> RTNL.  If the caller is bnxt_sp_task() which does not automatically
> take RTNL, we add a common scheme for bnxt_sp_task() to call these
> functions properly under RTNL.

Series applied, thanks Michael.

You can sprinkle some ASSERT_RTNL(); in the functions that require
RTNL to be held if you like.