lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Jan 2017 05:01:25 +0200 From: "Michael S. Tsirkin" <mst@...hat.com> To: Jakub Kicinski <jakub.kicinski@...ronome.com> Cc: netdev@...r.kernel.org, john.fastabend@...il.com, Alexei Starovoitov <alexei.starovoitov@...il.com>, Jason Wang <jasowang@...hat.com>, David Miller <davem@...emloft.net>, John Fastabend <john.r.fastabend@...el.com>, Daniel Borkmann <daniel@...earbox.net>, oss-drivers@...ronome.com Subject: Re: [PATCH net resend] virtio_net: reject XDP programs using header adjustment On Wed, Jan 25, 2017 at 02:56:36PM -0800, Jakub Kicinski wrote: > commit 17bedab27231 ("bpf: xdp: Allow head adjustment in XDP prog") > added a new XDP helper to prepend and remove data from a frame. > Make virtio_net reject programs making use of this helper until > proper support is added. > > Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com> > Acked-by: John Fastabend <john.r.fastabend@...el.com> Acked-by: Michael S. Tsirkin <mst@...hat.com> > --- > drivers/net/virtio_net.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index f9bf94887ff1..a2aac4fd8e42 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1710,6 +1710,11 @@ static int virtnet_xdp_set(struct net_device *dev, struct bpf_prog *prog) > u16 xdp_qp = 0, curr_qp; > int i, err; > > + if (prog && prog->xdp_adjust_head) { > + netdev_warn(dev, "Does not support bpf_xdp_adjust_head()\n"); > + return -EOPNOTSUPP; > + } > + > if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO4) || > virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO6) || > virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_ECN) || > -- > 2.11.0
Powered by blists - more mailing lists