netdev - Re: [PATCH net 2/5] ibmvnic: Fix MTU settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170126.125658.909712109140919732.davem@davemloft.net>
Date:   Thu, 26 Jan 2017 12:56:58 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, wvoigt@...ibm.com,
        jallen@...ux.vnet.ibm.com, linuxppc-dev@...ts.ozlabs.org,
        nfont@...ux.vnet.ibm.com
Subject: Re: [PATCH net 2/5] ibmvnic: Fix MTU settings

From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
Date: Thu, 26 Jan 2017 10:44:31 -0600

> On 01/25/2017 10:05 PM, David Miller wrote:
>> From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
>> Date: Wed, 25 Jan 2017 15:02:20 -0600
>>
>>> In the current driver, the MTU is set to the maximum value
>>> capable for the backing device. This patch sets the MTU to the
>>> default value for a Linux net device.
>> Why are you doing this?
>>
>> What happens to users who depend upon the current behavior.
>>
>> They will break, and that isn't acceptable.
>>
> The current behavior was already broken.  We were seeing firmware errors when sending jumbo sized packets .  We plan to add proper support for jumbo sized packets as soon as possible.  

Need to be explained, with a full detailed history of how things got this way,
in your commit message.