netdev - Re: [PATCH net-next 1/4] net: dsa: Pass device pointer to dsa_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ddfc22b3-f89e-4756-2585-dcf5cada7a23@gmail.com>
Date:   Thu, 26 Jan 2017 10:37:31 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     netdev@...r.kernel.org
Cc:     andrew@...n.ch, vivien.didelot@...oirfairelinux.com,
        davem@...emloft.net
Subject: Re: [PATCH net-next 1/4] net: dsa: Pass device pointer to
 dsa_register_switch

On 01/26/2017 10:28 AM, Florian Fainelli wrote:
> In preparation for allowing dsa_register_switch() to be supplied with
> device/platform data, pass down a struct device pointer instead of a
> struct device_node.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Need to revisit this:

drivers/net/dsa/mv88e6xxx/chip.c: In function 'mv88e6xxx_probe':
drivers/net/dsa/mv88e6xxx/chip.c:4460:3: error: implicit declaration of
function 'mv88e6xxx_mdio_unregister' [-Werror=implicit-function-declaration]
   mv88e6xxx_mdio_unregister(chip);
   ^
cc1: some warnings being treated as errors
scripts/Makefile.build:293: recipe for target
'drivers/net/dsa/mv88e6xxx/chip.o' failed
make[6]: *** [drivers/net/dsa/mv88e6xxx/chip.o] Error 1
scripts/Makefile.build:551: recipe for target
'drivers/net/dsa/mv88e6xxx' failed
make[5]: *** [drivers/net/dsa/mv88e6xxx] Error 2
make[5]: *** Waiting for unfinished jobs....

Take that kbuild robot!
-- 
Florian