netdev - Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <b6646479-b370-b19b-48e2-27e20f67a31a@linux.vnet.ibm.com>
Date:   Thu, 26 Jan 2017 13:05:40 -0600
From:   Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, wvoigt@...ibm.com,
        jallen@...ux.vnet.ibm.com, linuxppc-dev@...ts.ozlabs.org,
        nfont@...ux.vnet.ibm.com
Subject: Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

On 01/26/2017 12:28 PM, Stephen Hemminger wrote:
> On Wed, 25 Jan 2017 15:02:19 -0600
> Thomas Falcon <tlfalcon@...ux.vnet.ibm.com> wrote:
>
>>  static irqreturn_t ibmvnic_interrupt(int irq, void *instance)
>>  {
>>  	struct ibmvnic_adapter *adapter = instance;
>> +	unsigned long flags;
>> +
>> +	spin_lock_irqsave(&adapter->crq.lock, flags);
>> +	vio_disable_interrupts(adapter->vdev);
>> +	tasklet_schedule(&adapter->tasklet);
>> +	spin_unlock_irqrestore(&adapter->crq.lock, flags);
>> +	return IRQ_HANDLED;
>> +}
>> +
> Why not use NAPI? rather than a tasklet
>
This interrupt function doesn't process packets, but message passing between firmware and driver for determining device capabilities and available resources, such as the number TX and RX queues.