netdev - Re: [PATCH 2/7] batman-adv: Treat NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170125.225624.965229145391320056.davem@davemloft.net>
Date:   Wed, 25 Jan 2017 22:56:24 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sw@...onwunderlich.de
Cc:     netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org,
        gfree.wind@...il.com, sven@...fation.org
Subject: Re: [PATCH 2/7] batman-adv: Treat NET_XMIT_CN as transmit
 successfully

From: Simon Wunderlich <sw@...onwunderlich.de>
Date: Wed, 25 Jan 2017 17:42:58 +0100

> From: Gao Feng <gfree.wind@...il.com>
> 
> The tc could return NET_XMIT_CN as one congestion notification, but
> it does not mean the packet is lost. Other modules like ipvlan,
> macvlan, and others treat NET_XMIT_CN as success too.
> 
> So batman-adv should add the NET_XMIT_CN check.
> 
> Signed-off-by: Gao Feng <gfree.wind@...il.com>
> Signed-off-by: Sven Eckelmann <sven@...fation.org>
> Signed-off-by: Simon Wunderlich <sw@...onwunderlich.de>

Instead of all of this churn, just change the dev_queue_xmit() call in
net/batman-adv/send.c to be:

	return net_xmit_eval(dev_queue_xmit(skb));