netdev - RE: [PATCH net v2 3/4] r8152: re-schedule napi for tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0835B3720019904CB8F7AA43166CEEB201A136FC@RTITMBSV06.realtek.com.tw>
Date:   Thu, 26 Jan 2017 01:22:07 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH net v2 3/4] r8152: re-schedule napi for tx

Eric Dumazet [mailto:eric.dumazet@...il.com]
> Sent: Wednesday, January 25, 2017 9:57 PM
[...]
> >  		napi_complete(napi);
> >  		if (!list_empty(&tp->rx_done))
> >  			napi_schedule(napi);
> > +		else if (!skb_queue_empty(&tp->tx_queue) &&
> > +			 !list_empty(&tp->tx_free))
> > +			napi_schedule(&tp->napi);
> 
> Why using &tp->napi instead of napi here, as done 3 lines above ?

Oops. I would fix it. Thanks.

Best Regards,
Hayes