netdev - Re: [PATCH 0/5] GTP: Fine-tuning for some function implementations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1065111512.617676.1485429247267.JavaMail.zimbra@tpip.net>
Date:   Thu, 26 Jan 2017 12:14:07 +0100 (CET)
From:   Andreas Schultz <aschultz@...p.net>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Alexey Dobriyan <adobriyan@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        laforge <laforge@...monks.org>,
        Johannes Berg <johannes.berg@...el.com>,
        pablo <pablo@...filter.org>, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 0/5] GTP: Fine-tuning for some function implementations

Hi Markus,

----- On Jan 26, 2017, at 11:15 AM, SF Markus Elfring elfring@...rs.sourceforge.net wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 26 Jan 2017 11:10:01 +0100
> 
> A few update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (5):
>  Use kmalloc_array() in gtp_hashtable_new()
>  Improve another size determination in ipv4_pdp_add()
>  Adjust 12 checks for null pointers
>  Rename jump labels in gtp_encap_enable()
>  Rename jump labels in gtp_hashtable_new()

Looks good to me, for all the above:

Reviewed-by: Andreas Schultz <aschultz@...p.net>

Andreas

> 
> drivers/net/gtp.c | 46 ++++++++++++++++++++++++----------------------
> 1 file changed, 24 insertions(+), 22 deletions(-)
> 
> --
> 2.11.0