netdev - Re: [PATCH net-next] net: adjust skb->truesize in pskb_expand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201701271009.NCgqcrWI%fengguang.wu@intel.com>
Date:   Fri, 27 Jan 2017 10:22:48 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     kbuild-all@...org, David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Slava Shwartsman <slavash@...lanox.com>
Subject: Re: [PATCH net-next] net: adjust skb->truesize in pskb_expand_head()

Hi Eric,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-adjust-skb-truesize-in-pskb_expand_head/20170127-082517
config: i386-randconfig-x0-01270914 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/list.h:4,
                    from include/linux/module.h:9,
                    from net/core/skbuff.c:41:
   net/core/skbuff.c: In function 'pskb_expand_head':
   net/core/skbuff.c:1265:37: error: 'sock_edemux' undeclared (first use in this function)
     if (!skb->sk || skb->destructor == sock_edemux)
                                        ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> net/core/skbuff.c:1265:2: note: in expansion of macro 'if'
     if (!skb->sk || skb->destructor == sock_edemux)
     ^~
   net/core/skbuff.c:1265:37: note: each undeclared identifier is reported only once for each function it appears in
     if (!skb->sk || skb->destructor == sock_edemux)
                                        ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> net/core/skbuff.c:1265:2: note: in expansion of macro 'if'
     if (!skb->sk || skb->destructor == sock_edemux)
     ^~

vim +/if +1265 net/core/skbuff.c

  1249		skb->end      = size;
  1250		off           = nhead;
  1251	#else
  1252		skb->end      = skb->head + size;
  1253	#endif
  1254		skb->tail	      += off;
  1255		skb_headers_offset_update(skb, nhead);
  1256		skb->cloned   = 0;
  1257		skb->hdr_len  = 0;
  1258		skb->nohdr    = 0;
  1259		atomic_set(&skb_shinfo(skb)->dataref, 1);
  1260	
  1261		/* It is not generally safe to change skb->truesize.
  1262		 * For the moment, we really care of rx path, or
  1263		 * when skb is orphaned (not attached to a socket)
  1264		 */
> 1265		if (!skb->sk || skb->destructor == sock_edemux)
  1266			skb->truesize += size - osize;
  1267	
  1268		return 0;
  1269	
  1270	nofrags:
  1271		kfree(data);
  1272	nodata:
  1273		return -ENOMEM;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (25232 bytes)