netdev - Re: [PATCH RFC ipsec-next 2/2] xfrm: Add a dummy network device for napi.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485530754.6360.53.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Fri, 27 Jan 2017 07:25:54 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     steffen.klassert@...unet.com, netdev@...r.kernel.org,
        sowmini.varadhan@...cle.com, ilant@...lanox.com
Subject: Re: [PATCH RFC ipsec-next 2/2] xfrm: Add a dummy network device for
 napi.

On Fri, 2017-01-27 at 09:53 -0500, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Fri, 27 Jan 2017 06:46:38 -0800
> 
> > On Fri, 2017-01-27 at 08:19 +0100, Steffen Klassert wrote:
> >> This patch adds a dummy network device so that we can
> >> use gro_cells for IPsec GRO. With this, we handle IPsec
> >> GRO with no impact on the generic networking code.
> >> 
> >> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
> >> ---
> >>  net/xfrm/xfrm_input.c | 12 +++++++++++-
> >>  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > That is nice ;)
> 
> I like it too.
> 

If XFRM makes use of gro_cells, it is time to move it in net/core,
instead of inlining it.

I can submit this trivial patch, of course.

> I suspect we can do something similar for USB networking drivers.

With some changes then, because gro_cells is per cpu at the moment,
probably overkill for one USB networking driver.