netdev - Re: [PATCH net] tcp: don't annotate mark on control socket from tcp_v6_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170127.103420.1380044626135112317.davem@davemloft.net>
Date:   Fri, 27 Jan 2017 10:34:20 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     pablo@...filter.org
Cc:     netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
        eric.dumazet@...il.com
Subject: Re: [PATCH net] tcp: don't annotate mark on control socket from
 tcp_v6_send_response()

From: Pablo Neira Ayuso <pablo@...filter.org>
Date: Thu, 26 Jan 2017 22:56:21 +0100

> Unlike ipv4, this control socket is shared by all cpus so we cannot use
> it as scratchpad area to annotate the mark that we pass to ip6_xmit().
> 
> Add a new parameter to ip6_xmit() to indicate the mark. The SCTP socket
> family caches the flowi6 structure in the sctp_transport structure, so
> we cannot use to carry the mark unless we later on reset it back, which
> I discarded since it looks ugly to me.
> 
> Fixes: bf99b4ded5f8 ("tcp: fix mark propagation with fwmark_reflect enabled")
> Suggested-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

Looks good to me and matches Eric's suggestion.

Applied, thanks Pablo.