netdev - Re: [PATCH] net: phy: broadcom: add support for BCM54210E

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Jan 2017 20:50:16 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Rafał Miłecki <zajec5@...il.com>
Cc:     kbuild-all@...org, "David S . Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Xo Wang <xow@...gle.com>, Joel Stanley <joel@....id.au>,
        Jon Mason <jon.mason@...adcom.com>,
        Jaedon Shin <jaedon.shin@...il.com>, netdev@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH] net: phy: broadcom: add support for BCM54210E

Hi Rafał,

[auto build test WARNING on net-next/master]
[also build test WARNING on v4.10-rc5 next-20170125]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/net-phy-broadcom-add-support-for-BCM54210E/20170127-190002
config: x86_64-randconfig-s5-01271950 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/phy.h:19:0,
                    from drivers/net/phy/bcm-phy-lib.h:17,
                    from drivers/net/phy/broadcom.c:17:
   drivers/net/phy/broadcom.c: In function 'bcm54xx_config_init':
   drivers/net/phy/broadcom.c:249:32: error: 'PHY_ID_BCM54210E' undeclared (first use in this function)
     if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54210E) {
                                   ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/net/phy/broadcom.c:249:2: note: in expansion of macro 'if'
     if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54210E) {
     ^~
   drivers/net/phy/broadcom.c:249:32: note: each undeclared identifier is reported only once for each function it appears in
     if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54210E) {
                                   ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/net/phy/broadcom.c:249:2: note: in expansion of macro 'if'
     if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54210E) {
     ^~
   drivers/net/phy/broadcom.c: At top level:
   drivers/net/phy/broadcom.c:565:13: error: 'PHY_ID_BCM54210E' undeclared here (not in a function)
     .phy_id  = PHY_ID_BCM54210E,
                ^~~~~~~~~~~~~~~~
   drivers/net/phy/broadcom.c:714:4: error: initializer element is not constant
     { PHY_ID_BCM54210E, 0xfffffff0 },
       ^~~~~~~~~~~~~~~~
   drivers/net/phy/broadcom.c:714:4: note: (near initialization for 'broadcom_tbl[2].phy_id')

vim +/if +249 drivers/net/phy/broadcom.c

   233			MII_BCM54XX_INT_SPEED |
   234			MII_BCM54XX_INT_LINK);
   235		err = phy_write(phydev, MII_BCM54XX_IMR, reg);
   236		if (err < 0)
   237			return err;
   238	
   239		if ((BRCM_PHY_MODEL(phydev) == PHY_ID_BCM50610 ||
   240		     BRCM_PHY_MODEL(phydev) == PHY_ID_BCM50610M) &&
   241		    (phydev->dev_flags & PHY_BRCM_CLEAR_RGMII_MODE))
   242			bcm_phy_write_shadow(phydev, BCM54XX_SHD_RGMII_MODE, 0);
   243	
   244		if ((phydev->dev_flags & PHY_BRCM_RX_REFCLK_UNUSED) ||
   245		    (phydev->dev_flags & PHY_BRCM_DIS_TXCRXC_NOENRGY) ||
   246		    (phydev->dev_flags & PHY_BRCM_AUTO_PWRDWN_ENABLE))
   247			bcm54xx_adjust_rxrefclk(phydev);
   248	
 > 249		if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54210E) {
   250			err = bcm54210e_config_init(phydev);
   251			if (err)
   252				return err;
   253		} else if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54810) {
   254			err = bcm54810_config(phydev);
   255			if (err)
   256				return err;
   257		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32428 bytes)