netdev - bonding l2tpeth interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 27 Jan 2017 15:02:25 +0100
From:   Milan Kočvara <milankocvara@...il.com>
To:     netdev@...r.kernel.org
Subject: bonding l2tpeth interfaces

Hello.
I would like ask you about bonding l2tpeth interfaces. I found an older 
patch to allow it (interfaces were created over l2tpv3tun package) but 
after switching this functionality into ip route package starting kernel 
4.4 this patch does not work.

ifenslave says
ifenslave: bond0: can't set hw address
ifenslave: can't enslave l2tpeth1 to bond0: Resource busy
and doing over echo l2tpeth1 > /sys/class/net/bond0/bonding/
it says [  100.892608] bond0: interface 2tpeth1 does not exist!

patch was

diff --git a/net/l2tp/l2tp_eth.c b/net/l2tp/l2tp_eth.c
index 76125c5..1e73b35 100644
--- a/net/l2tp/l2tp_eth.c
+++ b/net/l2tp/l2tp_eth.c
@@ -120,12 +120,13 @@ static struct rtnl_link_stats64 
*l2tp_eth_get_stats64(struct net_device *dev,
         return stats;
  }

-
  static struct net_device_ops l2tp_eth_netdev_ops = {
         .ndo_init               = l2tp_eth_dev_init,
         .ndo_uninit             = l2tp_eth_dev_uninit,
         .ndo_start_xmit         = l2tp_eth_dev_xmit,
         .ndo_get_stats64        = l2tp_eth_get_stats64,
+       .ndo_validate_addr      = eth_validate_addr,
+       .ndo_set_mac_address    = eth_mac_addr,
  };

  static void l2tp_eth_dev_setup(struct net_device *dev)
-- 
1.7.9.5

this row > .ndo_set_mac_address    = eth_mac_addr, is part of current 
source.

What should be wrong yet, please?

My router is
Linux lede 4.4.42 #0 Wed Jan 25 15:25:48 2017 mips GNU/Linux