netdev - Re: [net-next v2] openvswitch: Simplify do_execute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_DTpWirOLqE3NgkFXjzAytZwdpCwDwPbnaDF2ZmN_9mqg@mail.gmail.com>
Date:   Fri, 27 Jan 2017 21:35:39 -0800
From:   Pravin Shelar <pshelar@....org>
To:     Andy Zhou <azhou@....org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [net-next v2] openvswitch: Simplify do_execute_actions().

On Fri, Jan 27, 2017 at 1:45 PM, Andy Zhou <azhou@....org> wrote:
> do_execute_actions() implements a worthwhile optimization: in case
> an output action is the last action in an action list, skb_clone()
> can be avoided by outputing the current skb. However, the
> implementation is more complicated than necessary.  This patch
> simplify this logic.
>
> Signed-off-by: Andy Zhou <azhou@....org>
> ---
> v1->v2:  drop skb NULL check in do_output()
>

Acked-by: Pravin B Shelar <pshelar@....org>

Thanks.