netdev - Re: [PATCH v3] can: Fix kernel panic at security_sock_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170129.183406.1410276231781823069.davem@davemloft.net>
Date:   Sun, 29 Jan 2017 18:34:06 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     socketcan@...tkopp.net, shuo.a.liu@...el.com,
        yanmin_zhang@...ux.intel.com, shuox.liu@...il.com,
        yanmin.zhang@...el.com, bo.he@...el.com, mkl@...gutronix.de,
        linux-can@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3] can: Fix kernel panic at security_sock_rcv_skb

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 27 Jan 2017 08:11:44 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Zhang Yanmin reported crashes [1] and provided a patch adding a
> synchronize_rcu() call in can_rx_unregister()
> 
> The main problem seems that the sockets themselves are not RCU
> protected.
> 
> If CAN uses RCU for delivery, then sockets should be freed only after
> one RCU grace period.
> 
> Recent kernels could use sock_set_flag(sk, SOCK_RCU_FREE), but let's
> ease stable backports with the following fix instead.
 ...
> Reported-by: Zhang Yanmin <yanmin.zhang@...el.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks Eric.