netdev - Re: [PATCH v2 iproute2] f_flower: don't set TCA_FLOWER_KEY_ETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170129202454.46c4c661@xeon-e3>
Date:   Sun, 29 Jan 2017 20:24:54 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Benjamin LaHaise <benjamin.lahaise@...ronome.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, netdev@...r.kernel.org,
        bcrl@...ck.org
Subject: Re: [PATCH v2 iproute2] f_flower: don't set TCA_FLOWER_KEY_ETH_TYPE
 for "protocol all"

On Fri, 20 Jan 2017 14:07:38 -0500
Benjamin LaHaise <benjamin.lahaise@...ronome.com> wrote:

> v2 - update to address changes in 00697ca19ae3e1118f2af82c3b41ac4335fe918b.
> 
> When using the tc flower filter, rules marked with "protocol all" do not
> actually match all packets.  This is due to a bug in f_flower.c that passes
> in ETH_P_ALL in the TCA_FLOWER_KEY_ETH_TYPE attribute when adding a rule.
> Fix this by omitting TCA_FLOWER_KEY_ETH_TYPE if the protocol is set to
> ETH_P_ALL.
>     
> Fixes: 488b41d020fb ("tc: flower no need to specify the ethertype")
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Benjamin LaHaise <benjamin.lahaise@...ronome.com>
> Signed-off-by: Benjamin LaHaise <bcrl@...ck.org>

Applied, thanks.