netdev - Re: [PATCH net-next V3 5/8] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170130.152532.370636093483999005.davem@davemloft.net>
Date:   Mon, 30 Jan 2017 15:25:32 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     David.Laight@...LAB.COM
Cc:     tariqt@...lanox.com, netdev@...r.kernel.org, eranbe@...lanox.com,
        lariel@...lanox.com
Subject: Re: [PATCH net-next V3 5/8] net/mlx4_en: Adding support of turning
 off link autonegotiation via ethtool

From: David Laight <David.Laight@...LAB.COM>
Date: Mon, 30 Jan 2017 14:00:28 +0000

> From: Tariq Toukan
>> Sent: 29 January 2017 16:56
>> From: Ariel Levkovich <lariel@...lanox.com>
>> 
>> This feature will allow the user to disable auto negotiation
>> on the port for mlx4 devices while setting the speed is limited
>> to 1GbE speeds.
>> Other speeds will not be accepted in autoneg off mode.
> 
> What is the rationale behind this change?

Because it's an ethtool user feature we've had to two decades
and it allows the user greater control over the link state.

> When I was writing ethernet drivers it was always better to
> leave autonegotiation enabled with restricted modes than to
> fix the speed.

Nothing about this change effects this.  The user is just given
the ability to turn autonegotiation off if they wish to do so.