netdev - Re: [PATCH net-next] net: ethtool: silence kmalloc warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170130.155006.811869833463169479.davem@davemloft.net>
Date:   Mon, 30 Jan 2017 15:50:06 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ast@...com
Cc:     edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: ethtool: silence kmalloc warning

From: Alexei Starovoitov <ast@...com>
Date: Sat, 28 Jan 2017 17:17:05 -0800

> under memory pressure 'ethtool -S' command may warn:
> [ 2374.385195] ethtool: page allocation failure: order:4, mode:0x242c0c0
 ...
> ~1160 mlx5 counters ~= order 4 allocation which is unlikely to succeed
> under memory pressure.  Since 'get stats' command is not critical
> avoid reclaim and warning.
> Also convert to safer kmalloc_array.
> 
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>

Let's just fix this right, just like in ethtool_get_regs().

Just use vzalloc() unconditionally.  It is an entirely similar
situation.  But please be careful with the size calculations when
you make this adjustment.

Thank you.