netdev - Re: [PATCH] net: aquantia: atlantic: use new api ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC=8w93PE4jv-j+66qOxtXvfb5jRNskWhunDwd3BfQsLsci78w@mail.gmail.com>
Date:   Mon, 30 Jan 2017 22:26:44 +0100
From:   Philippe Reynes <tremyfr@...il.com>
To:     Pavel Belous <pavel.s.belous@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: aquantia: atlantic: use new api ethtool_{get|set}_link_ksettings

Hi Pavel,

On 1/30/17, Pavel Belous <pavel.s.belous@...il.com> wrote:
> Hi Philippe,
>
> thanks you for your patch, it looks good.
> One improvement - could you please add support/advertising for TP?
>
>>+	supported |= SUPPORTED_Autoneg;
> need:
> 	supported |= SUPPORTED_TP;
>
>
>>+	advertising = (self->aq_nic_cfg.is_autoneg) ?
>> 							ADVERTISED_Autoneg : 0U;
>
> need:
> 	advertising |= ADVERTISED_TP;
>

Yes, of course, I add send, and I send a v2.

> Thank you.

Regards,
Philippe