netdev - Re: [PATCH net] net/sched: cls_flower: Correct matching on ICMPv6 code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170130.164241.1548388357085490430.davem@davemloft.net>
Date:   Mon, 30 Jan 2017 16:42:41 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     simon.horman@...ronome.com
Cc:     dinan.gunawardena@...ronome.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net] net/sched: cls_flower: Correct matching on ICMPv6
 code

From: Simon Horman <simon.horman@...ronome.com>
Date: Mon, 30 Jan 2017 16:19:02 +0100

> When matching on the ICMPv6 code ICMPV6_CODE rather than
> ICMPV4_CODE attributes should be used.
> 
> This corrects what appears to be a typo.
> 
> Sample usage:
> 
> tc qdisc add dev eth0 ingress
> tc filter add dev eth0 protocol ipv6 parent ffff: flower \
> 	indev eth0 ip_proto icmpv6 type 128 code 0 action drop
> 
> Without this change the code parameter above is effectively ignored.
> 
> Fixes: 7b684884fbfa ("net/sched: cls_flower: Support matching on ICMP type and code")
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>

Applied, thanks a lot Simon.