netdev - RE: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/ gfar_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM5PR0401MB2561120B6F9BE9FF0A46A0E1964B0@AM5PR0401MB2561.eurprd04.prod.outlook.com>
Date:   Mon, 30 Jan 2017 08:43:32 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Arseny Solokha <asolokha@...kras.ru>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue
 w/ gfar_new_page

>-----Original Message-----
>From: Arseny Solokha [mailto:asolokha@...kras.ru]
>Sent: Sunday, January 29, 2017 2:52 PM
>To: Claudiu Manoil <claudiu.manoil@....com>
>Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Arseny Solokha
><asolokha@...kras.ru>
>Subject: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/
>gfar_new_page
>
>From: Arseny Solokha <asolokha@...kras.ru>
>
>In spite of switching to paged allocation of Rx buffers, the driver still
>called dma_unmap_single() in the Rx queues tear-down path.
>

Except for the dma-debug part generating the warning, the implementation of 
dma_unmap_single() looks identical to dma_unmap_page(), both wrappers calling 
ops->unmap_page() with same params.
But for consistency, dma_unmap_page() seems the better choice indeed.
Thanks.

Acked-by: Claudiu Manoil <claudiu.manoil@....com>