netdev - RE: [PATCH 1/2] batman-adv: Fix double call of dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DB0273A88@AcuExch.aculab.com>
Date:   Mon, 30 Jan 2017 12:07:19 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Simon Wunderlich' <sw@...onwunderlich.de>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "b.a.t.m.a.n@...ts.open-mesh.org" <b.a.t.m.a.n@...ts.open-mesh.org>,
        "Sven Eckelmann" <sven@...fation.org>
Subject: RE: [PATCH 1/2] batman-adv: Fix double call of dev_queue_xmit

From: Simon Wunderlich
> Sent: 28 January 2017 10:57
> From: Sven Eckelmann <sven@...fation.org>
> 
> The net_xmit_eval has side effects because it is not making sure that e
> isn't evaluated twice.
> 
>     #define net_xmit_eval(e)        ((e) == NET_XMIT_CN ? 0 : (e))

It is probably worth fixing the #define.

	David