netdev - Re: [PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170130.095652.206333902555980419.davem@davemloft.net>
Date:   Mon, 30 Jan 2017 09:56:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     kafai@...com
Cc:     netdev@...r.kernel.org, bblanco@...mgrid.com, saeedm@...lanox.com,
        tariqt@...lanox.com, kernel-team@...com
Subject: Re: [PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L'
 or '-G'

From: Martin KaFai Lau <kafai@...com>
Date: Fri, 27 Jan 2017 23:40:51 -0800

> If the rx-queues ever get re-initialized (e.g. by changing the
> number of rx-queues with ethtool -L), the existing xdp_prog becomes
> inactive.
> 
> The bug is that the xdp_prog ptr has not been carried over from
> the old rx-queues to the new rx-queues
> 
> Fixes: 47a38e155037 ("net/mlx4_en: add support for fast rx drop bpf program")
> Signed-off-by: Martin KaFai Lau <kafai@...com>

Mellanox folks, please review.