netdev - Re: [PATCH] ipv6: fix flow labels when the traffic class is non-0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG76Sjb7J+pCZ4MhMYC-_L9_c587xA2XPqORGUFSZ9ESsouP5w@mail.gmail.com>
Date:   Mon, 30 Jan 2017 15:51:10 -0800
From:   Dimitris Michailidis <dmichail@...gle.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     Tom Herbert <tom@...bertland.com>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH] ipv6: fix flow labels when the traffic class is non-0

On Mon, Jan 30, 2017 at 3:45 PM, Eric Dumazet <edumazet@...gle.com> wrote:
> On Mon, Jan 30, 2017 at 3:40 PM, Tom Herbert <tom@...bertland.com> wrote:
>
>> Thanks for pointing out the issue, but I don't think this fix is quite
>> right. This would be discarding traffic class from being in the return
>> value. I can try to fix that.
>
> Fix looks fine to me.
>
> ip6_make_flowlabel() is usually used in an enclosing ip6_flow_hdr(),
> which gives the tclass.
>
> ip6_flow_hdr(hdr, tclass, ip6_make_flowlabel(net, skb, fl6->flowlabel,
>
>   np->autoflowlabel, fl6));

Yes, all the callers of ip6_make_flowlabel() I've seen feed the result
to ip6_flow_hdr().