netdev - Re: [PATCH 17/17] net: stmmac: replace unsigned by u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2017 11:12:04 +0100
From:   Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>,
        <alexandre.torgue@...com>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 17/17] net: stmmac: replace unsigned by u32

On 1/31/2017 10:11 AM, Corentin Labbe wrote:
> checkpatch complains about two unsigned without type after.
> Since the value return is u32, it is simpler to replace it by u32 instead
> of "unsigned int"
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>


Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index f0ce780..6260b6f 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -187,7 +187,7 @@ static void print_pkt(unsigned char *buf, int len)
>
>  static inline u32 stmmac_tx_avail(struct stmmac_priv *priv)
>  {
> -	unsigned avail;
> +	u32 avail;
>
>  	if (priv->dirty_tx > priv->cur_tx)
>  		avail = priv->dirty_tx - priv->cur_tx - 1;
> @@ -199,7 +199,7 @@ static inline u32 stmmac_tx_avail(struct stmmac_priv *priv)
>
>  static inline u32 stmmac_rx_dirty(struct stmmac_priv *priv)
>  {
> -	unsigned dirty;
> +	u32 dirty;
>
>  	if (priv->dirty_rx <= priv->cur_rx)
>  		dirty = priv->cur_rx - priv->dirty_rx;
>