netdev - Re: [PATCH][net-next] sfc: fix an off-by-one compare on an array size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170131.122602.1280692272369236886.davem@davemloft.net>
Date:   Tue, 31 Jan 2017 12:26:02 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ecree@...arflare.com
Cc:     colin.king@...onical.com, linux-net-drivers@...arflare.com,
        bkenward@...arflare.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][net-next] sfc: fix an off-by-one compare on an array
 size

From: Edward Cree <ecree@...arflare.com>
Date: Tue, 31 Jan 2017 16:37:10 +0000

> On 31/01/17 16:30, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> encap_type should be checked to see if it is greater or equal to
>> the size of array map to fix an off-by-one array size check. This
>> fixes an array overrun read as detected by static analysis by
>> CoverityScan, CID#1398883 ("Out-of-bounds-read")
>>
>> Fixes: 9b41080125176841e ("sfc: insert catch-all filters for encapsulated traffic")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Good catch.
> 
> Acked-by: Edward Cree <ecree@...arflare.com>

Applied, thanks everyone.