netdev - Re: [PATCH V2 3/3] net: bgmac: use PHY subsystem for initializing PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170131.131604.1471461660602159004.davem@davemloft.net>
Date:   Tue, 31 Jan 2017 13:16:04 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     zajec5@...il.com, jon.mason@...adcom.com, nbd@...nwrt.org,
        netdev@...r.kernel.org, rafal@...ecki.pl
Subject: Re: [PATCH V2 3/3] net: bgmac: use PHY subsystem for initializing
 PHY

From: David Miller <davem@...emloft.net>
Date: Tue, 31 Jan 2017 13:14:52 -0500 (EST)

> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Tue, 31 Jan 2017 10:06:34 -0800
> 
>> On 01/31/2017 10:04 AM, David Miller wrote:
>>> 
>>> This entire series is being held up because there is still questions about
>>> whether this is programming the internal PHYs and therefore whether the
>>> code should be placed elsewhere.
>>> 
>>> Can we please move the discussion forward?
>> 
>> The patches are good as-is, we can resolve the PHY programming later on
>> when we have figured out the details of the 4749 chip we derailed on.
> 
> Ok great, series applied, thanks.

Actually, reverted, I get build failures:

[davem@...p-10-15-49-210 net-next]$ make -s -j8
  DESCEND  objtool
Setup is 17084 bytes (padded to 17408 bytes).
System is 10211 kB
CRC 68863231
Kernel: arch/x86/boot/bzImage is ready  (#139)
ERROR: "bgmac_alloc" [drivers/net/ethernet/broadcom/bgmac-platform.ko] undefined!
ERROR: "bgmac_alloc" [drivers/net/ethernet/broadcom/bgmac-bcma.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1196: recipe for target 'modules' failed
make: *** [modules] Error 2