netdev - Re: [PATCH] rtnetlink: Handle IFLA_MASTER parameter when processing rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8cca96fb-572e-b7ac-92b0-916cbef1e60c@cumulusnetworks.com>
Date:   Tue, 31 Jan 2017 14:49:23 -0700
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Theuns Verwoerd <theuns.verwoerd@...iedtelesis.co.nz>,
        netdev@...r.kernel.org, roopa <roopa@...ulusnetworks.com>
Subject: Re: [PATCH] rtnetlink: Handle IFLA_MASTER parameter when processing
 rtnl_newlink

On 1/30/17 4:23 PM, Theuns Verwoerd wrote:
> Allow a master interface to be specified as one of the parameters when
> creating a new interface via rtnl_newlink.  Previously this would
> require invoking interface creation, waiting for it to complete, and
> then separately binding that new interface to a master.
> 
> In particular, this is used when creating a macvlan child interface for
> VRRP in a VRF configuration, allowing the interface creator to specify
> directly what master interface should be inherited by the child,
> without having to deal with asynchronous complications and potential
> race conditions.
> 
> Signed-off-by: Theuns Verwoerd <theuns.verwoerd@...iedtelesis.co.nz>
> ---
>  net/core/rtnetlink.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 

I can't see any harm in doing the enslavement in the same command that creates the link and it does simplify VRR setup.

Acked-by: David Ahern <dsa@...ulusnetworks.com>