netdev - Re: [PATCH] net: phy: broadcom: rehook BCM54612E specific init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170201.142032.218330612110187827.davem@davemloft.net>
Date:   Wed, 01 Feb 2017 14:20:32 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     zajec5@...il.com
Cc:     f.fainelli@...il.com, xow@...gle.com, joel@....id.au,
        jon.mason@...adcom.com, jaedon.shin@...il.com,
        netdev@...r.kernel.org, rafal@...ecki.pl
Subject: Re: [PATCH] net: phy: broadcom: rehook BCM54612E specific init

From: Rafa┅ Mi┅ecki <zajec5@...il.com>
Date: Tue, 31 Jan 2017 22:54:54 +0100

> From: Rafa┅ Mi┅ecki <rafal@...ecki.pl>
> 
> This extra BCM54612E code in PHY driver isn't really aneg specific. Even
> without it aneg works OK but the problem is no packets pass through PHY.
> 
> Moreover putting this code inside config_aneg callback didn't allow
> resuming PHY correctly. When driver called phy_stop and phy_start it was
> putting PHY machine into RESUMING state. After that machine was
> switching into AN and NOLINK without ever calling phy_start_aneg. This
> prevented this extra setup from being called and PHY didn't work.
> 
> This change has been verified to fix network on BCM47186B0 SoC device
> with BCM54612E.
> 
> Signed-off-by: Rafa┅ Mi┅ecki <rafal@...ecki.pl>

Applied to net-next, thanks.