netdev - Re: [PATCH] net: fix ndo_features_check/ndo_fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485909880.6360.141.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 31 Jan 2017 16:44:40 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Dimitris Michailidis <dmichail@...gle.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: fix ndo_features_check/ndo_fix_features comment
 ordering

On Tue, 2017-01-31 at 16:03 -0800, Dimitris Michailidis wrote:
> Commit cdba756f5803a2 ("net: move ndo_features_check() close to
> ndo_start_xmit()") inadvertently moved the doc comment for
> .ndo_fix_features instead of .ndo_features_check. Fix the comment
> ordering.
> 
> Fixes: cdba756f5803a2 ("net: move ndo_features_check() close to ndo_start_xmit()")
> Signed-off-by: Dimitris Michailidis <dmichail@...gle.com>
> ---


LGTM

Acked-by: Eric Dumazet <edumazet@...gle.com>

I am currently doing a reorg of net_device fields to improve locality,
I am not sure I will touch comments. We might do this later when things
are stabilized.