netdev - Re: [patch] ipv6: pointer math error in ip6_tnl_parse_tlv_enc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1485962777.6360.142.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 01 Feb 2017 07:26:17 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        James Morris <jmorris@...ei.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [patch] ipv6: pointer math error in ip6_tnl_parse_tlv_enc_lim()

On Wed, 2017-02-01 at 11:46 +0300, Dan Carpenter wrote:
> Casting is a high precedence operation but "off" and "i" are in terms of
> bytes so we need to have some parenthesis here.
> 
> Fixes: fbfa743a9d2a ("ipv6: fix ip6_tnl_parse_tlv_enc_lim()")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Silly me. Thanks Dan !

Acked-by: Eric Dumazet <edumazet@...gle.com>