netdev - Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 01 Feb 2017 16:01:17 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>
Cc:     jgross@...e.com, xen-devel@...ts.xenproject.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        vineethp@...zon.com, wei.liu2@...rix.com, paul.durrant@...rix.com,
        stable@...r.kernel.org, Ross Lagerwall <ross.lagerwall@...rix.com>
Subject: Re: [PATCH] xen-netfront: Delete rx_refill_timer in
 xennet_disconnect_backend()

On Wed, 2017-02-01 at 18:29 -0500, Boris Ostrovsky wrote:

> 
> I could not convince myself that napi_synchronize() is sufficient here
> (mostly because I am not familiar with napi flow). At the same time I
> would rather not make changes in anticipation of possible disappearance
> of netif_carrier_ok() in the future so I'd like this patch to go in as is.
> 
> Unless there are other problems with the patch or if Eric (or others)
> feel strongly about usage of netif_carrier_ok() here.
> 

No strong feelings from me.
We probably have more serious issues to fix anyway.