netdev - Re: [patch net-next 16/19] lib: Introduce priority array area manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1486075870.22276.43.camel@perches.com>
Date:   Thu, 02 Feb 2017 14:51:10 -0800
From:   Joe Perches <joe@...ches.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, idosch@...lanox.com, eladr@...lanox.com,
        mlxsw@...lanox.com, ogerlitz@...lanox.com, jhs@...atatu.com,
        ivecera@...hat.com, jbenc@...hat.com
Subject: Re: [patch net-next 16/19] lib: Introduce priority array area
 manager

On Thu, 2017-02-02 at 16:12 +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> This introduces a infrastructure for management of linear priority
> areas. Priority order in an array matters, however order of items inside
> a priority group does not matter.
> 
> As an initial implementation, L-sort algorithm is used. It is quite
> trivial. More advanced algorithm called P-sort will be introduced as a
> follow-up. The infrastructure is prepared for other algos.
> 
> Alongside this, a testing module is introduced as well.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  MAINTAINERS            |   8 +
>  include/linux/parman.h |  76 ++++++++++
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -9375,6 +9375,14 @@ F:	drivers/video/fbdev/sti*
>  F:	drivers/video/console/sti*
>  F:	drivers/video/logo/logo_parisc*
>  
> +PARMAN

This is not particularly descriptive.
Perhaps expand the section header a little like:

PARMAN - Linear priority array areas manager

> diff --git a/include/linux/parman.h b/include/linux/parman.h
[]
> @@ -0,0 +1,76 @@
> +/*
> + * include/linux/parman.h - Manager for linear priority array areas
[]
> diff --git a/lib/Kconfig b/lib/Kconfig
[]
> @@ -550,4 +550,7 @@ config STACKDEPOT
>  config SBITMAP
>  	bool
>  
> +config PARMAN
> +	tristate "parman"

help section?  Why should this be selected?