netdev - RE: [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to ifstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2017 08:53:22 +0000
From:   Nogah Frankel <nogahf@...lanox.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>,
        "roszenrami@...il.com" <roszenrami@...il.com>,
        "jbenc@...hat.com" <jbenc@...hat.com>,
        "sergei.shtylyov@...entembedded.com" 
        <sergei.shtylyov@...entembedded.com>,
        Jiri Pirko <jiri@...lanox.com>,
        "Elad Raz" <eladr@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Yotam Gigi <yotamg@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>
Subject: RE: [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to ifstat



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@...workplumber.org]
> Sent: Monday, January 30, 2017 6:34 AM
> To: Nogah Frankel <nogahf@...lanox.com>
> Cc: netdev@...r.kernel.org; roopa@...ulusnetworks.com; roszenrami@...il.com;
> jbenc@...hat.com; sergei.shtylyov@...entembedded.com; Jiri Pirko
> <jiri@...lanox.com>; Elad Raz <eladr@...lanox.com>; Ido Schimmel
> <idosch@...lanox.com>; Yotam Gigi <yotamg@...lanox.com>; Or Gerlitz
> <ogerlitz@...lanox.com>
> Subject: Re: [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to ifstat
> 
> On Thu, 26 Jan 2017 14:44:39 +0200
> Nogah Frankel <nogahf@...lanox.com> wrote:
> 
> > Extended stats are part of the RTM_GETSTATS method. This patch adds them
> > to ifstat.
> > While extended stats can come in many forms, we support only the
> > rtnl_link_stats64 struct for them (which is the 64 bits version of struct
> > rtnl_link_stats).
> > We support stats in the main nesting level, or one lower.
> > The extension can be called by its name or any shorten of it. If there is
> > more than one matched, the first one will be picked.
> >
> > To get the extended stats the flag -x <stats type> is used.
> 
> It would be better if this command used 64 bit statistics transparently
> like other tools in iproute2. Transparency is always better user experience.

From user point of view, all the statistics in ifstat are 64 bits and are saved that way.
We currently get the stats in 32 bits structs and translate them to 64 bits. It keeps track
of  int overflows (in the 32 bits).
The problem with it is  that if between one ifstat call to another passes too much time,
one might lose one of the overflows. 
But to change it is not a trivial matter, and I believe it is not related to the xstat feature I
want to add.
I don't think I understood what is the change you want.