netdev - Re: [PATCH v2] ethtool: do not vzalloc(0) on registers dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170203.111152.2232032272459625954.davem@davemloft.net>
Date:   Fri, 03 Feb 2017 11:11:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sgruszka@...hat.com
Cc:     netdev@...r.kernel.org, ben@...adent.org.uk
Subject: Re: [PATCH v2] ethtool: do not vzalloc(0) on registers dump

From: Stanislaw Gruszka <sgruszka@...hat.com>
Date: Thu,  2 Feb 2017 13:32:10 +0100

> If ->get_regs_len() callback return 0, we allocate 0 bytes of memory,
> what print ugly warning in dmesg, which can be found further below.
> 
> This happen on mac80211 devices where ieee80211_get_regs_len() just
> return 0 and driver only fills ethtool_regs structure and actually
> do not provide any dump. However I assume this can happen on other
> drivers i.e. when for some devices driver provide regs dump and for
> others do not. Hence preventing to to print warning in ethtool code
> seems to be reasonable.
 ...
> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
> ---
> v1 -> v2: nullify regbuf to avoid using uninitialized variable in line:
>           if (regbuf && copy_to_user(useraddr, regbuf, regs.len))

Applied, thanks.