netdev - Re: [PATCH net-next] trace: rename trace_print_hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170203.155045.1099357457146606258.davem@davemloft.net>
Date:   Fri, 03 Feb 2017 15:50:45 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     daniel@...earbox.net
Cc:     rostedt@...dmis.org, ast@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] trace: rename trace_print_hex_seq arg and add
 kdoc

From: Daniel Borkmann <daniel@...earbox.net>
Date: Thu,  2 Feb 2017 17:09:54 +0100

> Steven suggested to improve trace_print_hex_seq() a bit after commit
> 2acae0d5b0f7 ("trace: add variant without spacing in trace_print_hex_seq")
> in two ways: i) by adding a kdoc comment for the helper function
> itself and ii) by renaming 'spacing' argument into 'concatenate'
> to better denote that we don't add spaces between each hex bytes.
> 
> Suggested-by: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> ---
>  [ Sending as follow-up as original one is in net-next. ]

Applied, thanks Daniel.