netdev - Re: [patch net-next 16/19] lib: Introduce priority array area manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170203070109.GC1871@nanopsycho.orion>
Date:   Fri, 3 Feb 2017 08:01:09 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Joe Perches <joe@...ches.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com,
        eladr@...lanox.com, mlxsw@...lanox.com, ogerlitz@...lanox.com,
        jhs@...atatu.com, ivecera@...hat.com, jbenc@...hat.com
Subject: Re: [patch net-next 16/19] lib: Introduce priority array area manager

Thu, Feb 02, 2017 at 11:51:10PM CET, joe@...ches.com wrote:
>On Thu, 2017-02-02 at 16:12 +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> This introduces a infrastructure for management of linear priority
>> areas. Priority order in an array matters, however order of items inside
>> a priority group does not matter.
>> 
>> As an initial implementation, L-sort algorithm is used. It is quite
>> trivial. More advanced algorithm called P-sort will be introduced as a
>> follow-up. The infrastructure is prepared for other algos.
>> 
>> Alongside this, a testing module is introduced as well.
>> 
>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>> ---
>>  MAINTAINERS            |   8 +
>>  include/linux/parman.h |  76 ++++++++++
>[]
>> diff --git a/MAINTAINERS b/MAINTAINERS
>[]
>> @@ -9375,6 +9375,14 @@ F:	drivers/video/fbdev/sti*
>>  F:	drivers/video/console/sti*
>>  F:	drivers/video/logo/logo_parisc*
>>  
>> +PARMAN
>
>This is not particularly descriptive.
>Perhaps expand the section header a little like:
>
>PARMAN - Linear priority array areas manager

Okay


>
>> diff --git a/include/linux/parman.h b/include/linux/parman.h
>[]
>> @@ -0,0 +1,76 @@
>> +/*
>> + * include/linux/parman.h - Manager for linear priority array areas
>[]
>> diff --git a/lib/Kconfig b/lib/Kconfig
>[]
>> @@ -550,4 +550,7 @@ config STACKDEPOT
>>  config SBITMAP
>>  	bool
>>  
>> +config PARMAN
>> +	tristate "parman"
>
>help section?  Why should this be selected?

I did not put help on purpose, as for other libs. User should not never
need to select this directly because as standalone, it has no sense to
have it enabled. This is always selected by users - only mlxsw for now.


>