netdev - Re: [PATCH net-next 7/9] skge: use napi_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1486246609.21871.149.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Sat, 04 Feb 2017 14:16:49 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 7/9] skge: use napi_complete_done()

On Sat, 2017-02-04 at 13:44 -0800, Stephen Hemminger wrote:
> On Sat,  4 Feb 2017 10:20:36 -0800
> Eric Dumazet <edumazet@...gle.com> wrote:
> 
> >  
> > -static int skge_poll(struct napi_struct *napi, int to_do)
> > +static int skge_poll(struct napi_struct *napi, int budget)
> 
> Ok, but renaming parameter is not really necessary.

About all drivers use @budget for this parameter.

By having the same variable names, it is easier to compare various
implementations and spot common errors.

> 
> > -	if (work_done < to_do) {
> > +	if ((work_done < budget) && napi_complete_done(napi, work_done)) {
> >  		unsigned long flags;
> 
> Parenthesis around work_done < budget are unnecessary.

Yes, thanks you, I will do this in all the patches for V2.