lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 5 Feb 2017 15:32:19 +0100 From: Lukasz Majewski <lukma@...x.de> To: Andrew Lunn <andrew@...n.ch> Cc: Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Karicheri Muralidharan <m-karicheri2@...com>, linux-kernel@...r.kernel.org, Eric Engestrom <eric@...estrom.ch>, netdev@...r.kernel.org, Kishon Vijay Abraham I <kishon@...com>, Grygorii Strashko <grygorii.strashko@...com> Subject: Re: [PATCH v2 1/2] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver Hi Andrew, > On Sat, Feb 04, 2017 at 05:02:11PM +0100, Lukasz Majewski wrote: > > This patch adds support for enabling or disabling the port > > mirroring (at CFG4 register) feature of the DP83867 TI's PHY device. > > As we discussed before, "port mirroring" is bad naming. Yes, we should > use it, because that is what the datasheet calls this feature. That was my goal - to use naming from datasheet. > But the > commit message should also contain a description of what this means, > and reference that the linux name for this concept is lane swapping. Ok. No problem with that. > > > +enum { > > Maybe give the 0 value a name. DP83867_PORT_MIRROING_KEEP? I can add this - no problem. > > > + DP83867_PORT_MIRROING_EN = 1, > > + DP83867_PORT_MIRROING_DIS, > > +}; > > + > > That extra enum value can then make this more obvious: > > if (dp83867->port_mirroring != DP83867_PORT_MIRROING_KEEP) > dp83867_config_port_mirroring(phydev); > > On the first reading of the patch, i though you were setting mirroring > on/off under all conditions, but in fact you don't. This makes it > clearer. Ok. I see your point. > > Thanks > Andrew Thanks for review :-) Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@...x.de
Powered by blists - more mailing lists