netdev - Re: [PATCH net] ipv6: tcp: add a missing tcp_v6_restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170206.105322.954692203927224.davem@davemloft.net>
Date:   Mon, 06 Feb 2017 10:53:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, dvyukov@...gle.com
Subject: Re: [PATCH net] ipv6: tcp: add a missing tcp_v6_restore_cb()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 05 Feb 2017 20:23:22 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Dmitry reported use-after-free in ip6_datagram_recv_specific_ctl()
> 
> A similar bug was fixed in commit 8ce48623f0cf ("ipv6: tcp: restore
> IP6CB for pktoptions skbs"), but I missed another spot.
> 
> tcp_v6_syn_recv_sock() can indeed set np->pktoptions from ireq->pktopts
> 
> Fixes: 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line misses")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>

APplied and queued up for -stable, thanks Eric.