netdev - Re: pull-request: can-next 2017-02-06,pull-request: can-next 2017-02-06

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170206.111259.2261971436931731059.davem@davemloft.net>
Date:   Mon, 06 Feb 2017 11:12:59 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mkl@...gutronix.de
Cc:     netdev@...r.kernel.org, kernel@...gutronix.de,
        linux-can@...r.kernel.org
Subject: Re: pull-request: can-next 2017-02-06,pull-request: can-next
 2017-02-06

From: Marc Kleine-Budde <mkl@...gutronix.de>
Date: Mon, 6 Feb 2017 15:50:48 +0100

> this is a pull request of 16 patches for net-next/master.
> 
> The first two patches by David Jander and me add the rx-offload
> framework for CAN devices to the kernel. The remaining 14 patches
> convert the flexcan driver to make use of it.

Pulled, but I wonder if your comparisons does the right thing when the
counters overflow.

I think you need to do the same thing we do for TCP sequence number
comparisons and code it like:

static inline bool before(__u32 seq1, __u32 seq2)
{
        return (__s32)(seq1-seq2) < 0;
}