netdev - Re: [PATCH net] ipv6: Fix IPv6 packet loss in scenarios involving roaming + snooping switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170206.114329.1196570425826508517.davem@davemloft.net>
Date:   Mon, 06 Feb 2017 11:43:29 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     linus.luessing@...3.blue
Cc:     netdev@...r.kernel.org, kuznet@....inr.ac.ru, jmorris@...ei.org,
        yoshfuji@...ux-ipv6.org, kaber@...sh.net, monis@...taire.com,
        bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH net] ipv6: Fix IPv6 packet loss in scenarios involving
 roaming + snooping switches

From: Linus Lüssing <linus.luessing@...3.blue>
Date: Fri,  3 Feb 2017 08:11:03 +0100

> When for instance a mobile Linux device roams from one access point to
> another with both APs sharing the same broadcast domain and a
> multicast snooping switch in between:
> 
> 1)    (c) <~~~> (AP1) <--[SSW]--> (AP2)
> 
> 2)              (AP1) <--[SSW]--> (AP2) <~~~> (c)
> 
> Then currently IPv6 multicast packets will get lost for (c) until an
> MLD Querier sends its next query message. The packet loss occurs
> because upon roaming the Linux host so far stayed silent regarding
> MLD and the snooping switch will therefore be unaware of the
> multicast topology change for a while.
> 
> This patch fixes this by always resending MLD reports when an interface
> change happens, for instance from NO-CARRIER to CARRIER state.
> 
> Signed-off-by: Linus Lüssing <linus.luessing@...3.blue>

Looks good to me, applied, thanks.