netdev - Re: [PATCH net-next v2 2/6] gtp: merge gtp_get_net and gtp_genl_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170206135512.sbxvkbe3hzgnwwjt@nataraja>
Date:   Mon, 6 Feb 2017 14:55:12 +0100
From:   Harald Welte <laforge@...filter.org>
To:     Andreas Schultz <aschultz@...p.net>
Cc:     Pablo Neira <pablo@...filter.org>, netdev@...r.kernel.org,
        Lionel Gauthier <Lionel.Gauthier@...ecom.fr>,
        openbsc@...ts.osmocom.org
Subject: Re: [PATCH net-next v2 2/6] gtp: merge gtp_get_net and
 gtp_genl_find_dev

Hi Andreas,

On Mon, Jan 30, 2017 at 05:37:09PM +0100, Andreas Schultz wrote:
> Both function are always used together with the final goal to
> get the gtp_dev. This simplifies the code by merging them together.

Ok, some code restructuring / unification, seems useful.

However:

> -			netdev_dbg(dev, "GTPv0-U: update tunnel id = %llx (pdp %p)\n",
> -				   pctx->u.v0.tid, pctx);
> +			pr_debug("GTPv0-U: update tunnel id = %llx (pdp %p)\n",
> +				 pctx->u.v0.tid, pctx);

(and other related changes) appear to be purely cosmetic and should thus
be unrelated to the function merging described in the change log
message.

-- 
- Harald Welte <laforge@...filter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie