netdev - Re: [PATCH net-next] bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5899CA80.8030108@cumulusnetworks.com>
Date:   Tue, 07 Feb 2017 05:24:16 -0800
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
CC:     netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
        Colin Ian King <colin.king@...onical.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel_info

On 2/7/17, 3:46 AM, Nikolay Aleksandrov wrote:
> These checks should go after the attributes have been parsed otherwise
> we're using tb uninitialized.
>
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Reported-by: Colin Ian King <colin.king@...onical.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
>  
ouch, am surprised i did not catch this. Thanks Colin and Nikolay.